cromer/pamac-classic
2
0
Fork 3
Code Issues 2 Pull Requests 1 Releases 13 Wiki Activity

Add option to keep AUR packages #11

Merged
cromer merged 5 commits from matthiakl/pamac-classic:store_aur_pkgs into master 2021-07-10 15:58:09 -04:00
Conversation 1 Commits 5 Files Changed 6 +156 -26
matthiakl commented 2021-07-10 05:20:43 -04:00
Contributor
Copy Link

Adds an option to the AUR tab to enable and choose a folder, where built AUR packages are stored. I found this helpful for switching between versions of those packages.
I also updated the German translation and filled missing strings.

Adds an option to the AUR tab to enable and choose a folder, where built AUR packages are stored. I found this helpful for switching between versions of those packages. I also updated the German translation and filled missing strings.
matthiakl added 3 commits 2021-07-10 05:20:45 -04:00
cromer commented 2021-07-10 13:25:05 -04:00
Owner
Copy Link

This looks good. However 2 issues, there is a conflict in src/preferences_dialog.vala which comes from your libalpm branch that I already merged. Please rebase this on the master branch which now has the new libalpm changes.

The other issue is the way you copy using "cp". Please use the GLib.File from gio-2.0 to handle file moving/copying operations: https://valadoc.org/gio-2.0/GLib.File.html

By using those there is better error control through try and catch and to recover when the operation fails. If you update your code to use GLib.File, I will gladly merge it.

This looks good. However 2 issues, there is a conflict in src/preferences_dialog.vala which comes from your libalpm branch that I already merged. Please rebase this on the master branch which now has the new libalpm changes. The other issue is the way you copy using "cp". Please use the GLib.File from gio-2.0 to handle file moving/copying operations: https://valadoc.org/gio-2.0/GLib.File.html By using those there is better error control through try and catch and to recover when the operation fails. If you update your code to use GLib.File, I will gladly merge it.
cromer self-assigned this 2021-07-10 13:25:32 -04:00
matthiakl added 2 commits 2021-07-10 14:35:12 -04:00
cromer merged commit cdd9088d91 into master 2021-07-10 15:58:09 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
cromer
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cromer/pamac-classic#11
No description provided.
Delete Branch "matthiakl/pamac-classic:store_aur_pkgs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?