From 601b3c95cafa1683f95eb9d27107a6779983b127 Mon Sep 17 00:00:00 2001 From: Chris Cromer Date: Tue, 13 Nov 2018 09:15:33 -0300 Subject: [PATCH 1/4] add count sort --- Makefile | 2 +- src/count_sort.c | 49 ++++++++++++++++++++++++++++++++++++++++ src/include/count_sort.h | 19 ++++++++++++++++ src/sort.c | 7 +++++- test/Makefile | 2 +- test/test.c | 28 +++++++++++++++++++---- 6 files changed, 100 insertions(+), 7 deletions(-) create mode 100644 src/count_sort.c create mode 100644 src/include/count_sort.h diff --git a/Makefile b/Makefile index def505a..5d47608 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,7 @@ CC=gcc CFLAGS=-Wall -Isrc/include -DDEBUG -g #LDFLAGS=-lm -SRC=src/sort.c src/random.c src/bubble_sort.c src/timer.c +SRC=src/sort.c src/random.c src/bubble_sort.c src/timer.c src/count_sort.c OBJ=$(SRC:.c=.o) all: sort informe diff --git a/src/count_sort.c b/src/count_sort.c new file mode 100644 index 0000000..dab32e6 --- /dev/null +++ b/src/count_sort.c @@ -0,0 +1,49 @@ +/* + * Copyright 2018 Christopher Cromer + * Copyright 2018 Rodolfo Cuevas + * + * Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: + * + * 1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. + * + * 2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. + * + * 3. Neither the name of the copyright holder nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +#include +#include + +#include + +/** + * Usar el algoritmo de ordenameniento por conteo + * @param array El array a ordenar + * @param n El tamaño del array + */ +void count_sort(int *array, int n) { + int i; + int j; + int *temp = malloc(sizeof(int) * n); + int *count = malloc(sizeof(int) * n); + memcpy(temp, array, sizeof(int) * n); + for (i = 0; i < n - 1; i++) { + for (j = i + 1; j < n; j++) { + if (temp[i] < temp[j]) { + count[j]++; + } + else { + count[i]++; + } + } + } + + for (i = 0; i < n; i++) { + array[count[i]] = temp[i]; + } + + free(count); + free(temp); +} diff --git a/src/include/count_sort.h b/src/include/count_sort.h new file mode 100644 index 0000000..222a167 --- /dev/null +++ b/src/include/count_sort.h @@ -0,0 +1,19 @@ +/* + * Copyright 2018 Christopher Cromer + * Copyright 2018 Rodolfo Cuevas + * + * Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: + * + * 1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. + * + * 2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. + * + * 3. Neither the name of the copyright holder nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +#ifndef _SORT_COUNT + #define _SORT_COUNT + void count_sort(int *array, int n); +#endif diff --git a/src/sort.c b/src/sort.c index 4c353cf..1d08d23 100644 --- a/src/sort.c +++ b/src/sort.c @@ -19,6 +19,7 @@ #include "random.h" #include "timer.h" #include "bubble_sort.h" +#include "count_sort.h" #define SORT_VERSION "1.0.0" @@ -215,7 +216,11 @@ int main (int argc, char **argv) { // bitonic sort } else if (algoritmo == 4) { - // count sort + fprintf(stdout, "Count sort corriendo...\n"); + fflush(stdout); + start_timer(); + count_sort(array, n); + stop_timer(); } else if (algoritmo == 5) { // selection sort diff --git a/test/Makefile b/test/Makefile index 2b8cab0..2768c2f 100644 --- a/test/Makefile +++ b/test/Makefile @@ -2,7 +2,7 @@ CC=gcc CFLAGS=-Wall -I../src/include -DDEBUG -g SRC=test.c OBJ=$(SRC:.c=.o) -OBJ+=../src/random.o ../src/bubble_sort.o ../src/timer.o +OBJ+=../src/random.o ../src/bubble_sort.o ../src/timer.o ../src/count_sort.o all: test diff --git a/test/test.c b/test/test.c index c79ec27..b15bdd1 100644 --- a/test/test.c +++ b/test/test.c @@ -19,6 +19,7 @@ #include #include "random.h" #include "bubble_sort.h" +#include "count_sort.h" static int *test_case; static int *test_array; @@ -50,7 +51,7 @@ int main(int argc, char **argv) { int n = 50000; int i; int gen; - int pass = 1; + int pass; int passed = 0; int failed = 0; @@ -63,6 +64,7 @@ int main(int argc, char **argv) { fprintf(stdout, "Running tests:\n"); // Test random number generation + pass = 1; fprintf(stdout, "\trandom generation: "); fflush(stdout); for (i = 0; i < 5000000; i++) { @@ -78,22 +80,22 @@ int main(int argc, char **argv) { fprintf(stdout, "pass\n"); passed++; } - pass = 1; // Prepare for sort tests for (i = 0; i < n; i++) { test_case[i] = gen_rand(-100, 100); } memcpy(qarray, test_case, sizeof(int) * n); - memcpy(test_array, test_case, sizeof(int) * n); qsort(qarray, n, sizeof(int), compar); // Test bubble sort + pass = 1; + memcpy(test_array, test_case, sizeof(int) * n); fprintf(stdout, "\tbubble sort: "); fflush(stdout); bubble_sort(test_array, n); for (i = 0; i < n; i++) { - if (test_array[i] != qarray[i] && pass) { + if (test_array[i] != qarray[i]) { fprintf(stdout, "fail\n"); failed++; pass = 0; @@ -104,7 +106,25 @@ int main(int argc, char **argv) { fprintf(stdout, "pass\n"); passed++; } + + // Test count sort pass = 1; + memcpy(test_array, test_case, sizeof(int) * n); + fprintf(stdout, "\tcount sort: "); + fflush(stdout); + count_sort(test_array, n); + for (i = 0; i < n; i++) { + if (test_array[i] != qarray[i]) { + fprintf(stdout, "fail\n"); + failed++; + pass = 0; + break; + } + } + if (pass) { + fprintf(stdout, "pass\n"); + passed++; + } fprintf(stdout, "%d tests passed\n", passed); fprintf(stdout, "%d tests failed\n", failed); From 051d2b22cdb8071252f386139510c13cfa085cae Mon Sep 17 00:00:00 2001 From: Chris Cromer Date: Tue, 13 Nov 2018 09:16:15 -0300 Subject: [PATCH 2/4] remove extra include --- src/count_sort.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/count_sort.c b/src/count_sort.c index dab32e6..43d121c 100644 --- a/src/count_sort.c +++ b/src/count_sort.c @@ -16,8 +16,6 @@ #include #include -#include - /** * Usar el algoritmo de ordenameniento por conteo * @param array El array a ordenar From 6b395a8b0a11a172bef0493adb1e52b66c6e157d Mon Sep 17 00:00:00 2001 From: Chris Cromer Date: Tue, 13 Nov 2018 09:18:03 -0300 Subject: [PATCH 3/4] add missing doc --- src/bubble_sort.c | 5 +++++ src/sort.c | 3 +++ 2 files changed, 8 insertions(+) diff --git a/src/bubble_sort.c b/src/bubble_sort.c index 5b10ec0..44ab544 100644 --- a/src/bubble_sort.c +++ b/src/bubble_sort.c @@ -13,6 +13,11 @@ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +/** + * Usar el algoritmo de bubble sort + * @param array El array a ordenar + * @param n El tamaño del array + */ void bubble_sort(int *array, int n) { int i; int j = n; diff --git a/src/sort.c b/src/sort.c index 1d08d23..976b696 100644 --- a/src/sort.c +++ b/src/sort.c @@ -23,6 +23,9 @@ #define SORT_VERSION "1.0.0" +/** + * El array a ordenar + */ static int *array; /** From a43a470e7f1f17ce869f24a6e5e8e87eeca95e28 Mon Sep 17 00:00:00 2001 From: Chris Cromer Date: Tue, 13 Nov 2018 11:27:16 -0300 Subject: [PATCH 4/4] allow all algorithms to be run or a mix of them --- src/sort.c | 110 +++++++++++++++++++++++++--------------------------- src/timer.c | 19 +++++---- 2 files changed, 64 insertions(+), 65 deletions(-) diff --git a/src/sort.c b/src/sort.c index 976b696..551806c 100644 --- a/src/sort.c +++ b/src/sort.c @@ -16,6 +16,7 @@ #include #include #include +#include #include "random.h" #include "timer.h" #include "bubble_sort.h" @@ -26,13 +27,15 @@ /** * El array a ordenar */ -static int *array; +static int *unordered_array; +static int *work_array; /** * Imprimir el uso del programa */ void print_usage() { fprintf(stdout, "uso: sort [OPCIÓN]\n"); + fprintf(stdout, " -a, --all usar todos los algoritmos de ordenamentio\n"); fprintf(stdout, " -m, --merge usar merge sort\n"); fprintf(stdout, " -q, --quick usar quick sort\n"); fprintf(stdout, " -b, --bubble usar bubble sort\n"); @@ -48,15 +51,6 @@ void print_usage() { fprintf(stdout, " -v, --version mostrar la versión del programa\n"); } -/** - * Imprimir un mensaje de error y salir - */ -void extra_algorithm() { - fprintf(stderr, "Error: Solo se puede elegir un algoritmo al vez!\n"); - print_usage(); - exit(2); -} - /** * Imprimir un array * @param *array El array a imprimir @@ -74,7 +68,8 @@ void print_array(int *array, int n) { * Liberar la memoria al salir */ void cleanup() { - free(array); + free(unordered_array); + free(work_array); } /** @@ -87,10 +82,16 @@ int main (int argc, char **argv) { int n = 10; int elegir = 0; int imprimir = 0; - int algoritmo = -1; + int merge = 0; + int quick = 0; + int bubble = 0; + int bitonic = 0; + int count = 0; + int selection = 0; int opt; int long_index = 0; static struct option long_options[] = { + {"all", no_argument, 0, 'a'}, {"merge", no_argument, 0, 'm'}, {"quick", no_argument, 0, 'q'}, {"bubble", no_argument, 0, 'b'}, @@ -109,43 +110,33 @@ int main (int argc, char **argv) { return 0; } - while ((opt = getopt_long(argc, argv, "mqbBcsn:eiv", long_options, &long_index)) != -1) { + while ((opt = getopt_long(argc, argv, "amqbBcsn:eiv", long_options, &long_index)) != -1) { switch (opt) { + case 'a': + merge = 1; + quick = 1; + bubble = 1; + bitonic = 1; + count = 1; + selection = 1; + break; case 'm': - if (algoritmo != -1) { - extra_algorithm(); - } - algoritmo = 0; + merge = 1; break; case 'q': - if (algoritmo != -1) { - extra_algorithm(); - } - algoritmo = 1; + quick = 1; break; case 'b': - if (algoritmo != -1) { - extra_algorithm(); - } - algoritmo = 2; + bubble = 1; break; case 'B': - if (algoritmo != -1) { - extra_algorithm(); - } - algoritmo = 3; + bitonic = 1; break; case 'c': - if (algoritmo != -1) { - extra_algorithm(); - } - algoritmo = 4; + count = 1; break; case 's': - if (algoritmo != -1) { - extra_algorithm(); - } - algoritmo = 5; + selection = 1; break; case 'n': n = atol(optarg); @@ -170,13 +161,14 @@ int main (int argc, char **argv) { } } - if (algoritmo < 0 || algoritmo > 5) { + if (!merge && !quick && !bubble && !bitonic && !count && !selection) { fprintf(stderr, "Error: No se seleccionó un algoritmo valido!\n"); print_usage(); return 4; } - array = malloc(sizeof(int) * n); + unordered_array = malloc(sizeof(int) * n); + work_array = malloc(sizeof(int) * n); atexit(cleanup); // Llenar el array con valores para ordenar después @@ -190,50 +182,54 @@ int main (int argc, char **argv) { fprintf(stdout, "Número invalido! Tiene que ser mayor de 1!\n"); fprintf(stdout, "Elegir elemento %lli: ", i + 1); } - array[i] = opt; + unordered_array[i] = opt; } else { - array[i] = gen_rand((n * 10) * -1, n * 10); + unordered_array[i] = gen_rand((n * 10) * -1, n * 10); } } - if (imprimir) { - fprintf(stdout, "Antes:\n"); - print_array(array, n); - } - - if (algoritmo == 0) { + if (merge) { // merge sort } - else if (algoritmo == 1) { + + if (quick) { // quick sort } - else if (algoritmo == 2) { + + if (bubble) { fprintf(stdout, "Bubble sort corriendo...\n"); fflush(stdout); + memcpy(work_array, unordered_array, sizeof(int) * n); start_timer(); - bubble_sort(array, n); + bubble_sort(work_array, n); stop_timer(); + print_timer(); } - else if (algoritmo == 3) { + + if (bitonic) { // bitonic sort } - else if (algoritmo == 4) { + + if (count) { fprintf(stdout, "Count sort corriendo...\n"); fflush(stdout); + memcpy(work_array, unordered_array, sizeof(int) * n); start_timer(); - count_sort(array, n); + count_sort(work_array, n); stop_timer(); + print_timer(); } - else if (algoritmo == 5) { + + if (selection) { // selection sort } if (imprimir) { + fprintf(stdout, "\nAntes:\n"); + print_array(unordered_array, n); fprintf(stdout, "\nDespués:\n"); - print_array(array, n); + print_array(work_array, n); } - - print_timer(); return 0; } diff --git a/src/timer.c b/src/timer.c index 014633c..f7611fc 100644 --- a/src/timer.c +++ b/src/timer.c @@ -30,13 +30,8 @@ static time_t stop_time = 0; * Empezar el timer */ void start_timer() { - if (start_time != 0) { - fprintf(stderr, "Error: El temporizador ya comenzó!\n"); - } - else { - time(&start_time); - stop_time = 0; - } + time(&start_time); + stop_time = 0; } /** @@ -55,7 +50,15 @@ void stop_timer() { * Imprimir el tiempo de ejecución */ void print_timer() { - fprintf(stdout, "Tiempo de ejecución: %ld segundos\n", (long int) (stop_time - start_time)); + if (start_time == 0) { + fprintf(stderr, "Error: El temporizador no ha comenzado todavía!\n"); + } + else if (stop_time == 0) { + fprintf(stderr, "Error: El temporizador no ha terminado todavía!\n"); + } + else { + fprintf(stdout, "Tiempo de ejecución: %ld segundos\n", (long int) (stop_time - start_time)); + } } /**