From e62acd3ab1932a769092b2796fe06d8500afd639 Mon Sep 17 00:00:00 2001
From: Martin Araneda <martix.araneda@gmail.com>
Date: Thu, 1 Sep 2022 23:22:10 -0400
Subject: [PATCH] final changes to music

---
 godot/gui/GameOver.tscn              |  4 ++--
 src/gui/game_over/GameOverScreen.cpp | 13 +++++++++++--
 src/gui/game_over/GameOverScreen.h   |  2 +-
 3 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/godot/gui/GameOver.tscn b/godot/gui/GameOver.tscn
index 56c19a8..08d8f03 100644
--- a/godot/gui/GameOver.tscn
+++ b/godot/gui/GameOver.tscn
@@ -48,7 +48,7 @@ text = "REINICIAR"
 
 [node name="GameOverMusic" type="AudioStreamPlayer" parent="."]
 stream = ExtResource( 4 )
-volume_db = -23.524
+volume_db = -25.0
 
-[connection signal="visibility_changed" from="." to="." method="_play_music"]
+[connection signal="visibility_changed" from="." to="." method="_on_visibility_changed"]
 [connection signal="pressed" from="Control/RestartButton" to="." method="_on_restart_button_pressed"]
diff --git a/src/gui/game_over/GameOverScreen.cpp b/src/gui/game_over/GameOverScreen.cpp
index 622a032..9dcdf47 100644
--- a/src/gui/game_over/GameOverScreen.cpp
+++ b/src/gui/game_over/GameOverScreen.cpp
@@ -16,7 +16,7 @@ void alai::GameOverScreen::_register_methods()
     godot::register_method("restart_game", &GameOverScreen::restart_game);
     godot::register_method("connect_signal", &GameOverScreen::connect_signal);
     godot::register_method("_on_player_died", &GameOverScreen::_on_player_died);
-	godot::register_method("_play_music", &GameOverScreen::_play_music);
+	godot::register_method("_on_visibility_changed", &GameOverScreen::_on_visibility_changed);
 }
 
 alai::GameOverScreen::GameOverScreen()
@@ -96,6 +96,15 @@ void alai::GameOverScreen::connect_signal()
     event->connect("player_died", this, "_on_player_died");
 }
 
-void alai::GameOverScreen::_play_music()
+void alai::GameOverScreen::_on_visibility_changed()
 {
+    auto gameoversound = get_node<godot::AudioStreamPlayer>("GameOverMusic");
+    if (is_visible()) 
+    { 
+        gameoversound->play();
+    }
+    else
+    {
+        gameoversound->stop();
+    }
 }
diff --git a/src/gui/game_over/GameOverScreen.h b/src/gui/game_over/GameOverScreen.h
index 3fb679c..0dc7226 100644
--- a/src/gui/game_over/GameOverScreen.h
+++ b/src/gui/game_over/GameOverScreen.h
@@ -55,7 +55,7 @@ namespace alai
             void _on_restart_button_pressed();
             void restart_game();
             void connect_signal();
-            void _play_music();
+            void _on_visibility_changed();
     };
 }